Change in vdsm[master]: Raise ongoing creations count

danken at redhat.com danken at redhat.com
Mon Dec 26 20:11:57 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Raise ongoing creations count
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 267:     _ongoingCreations = threading.BoundedSemaphore(10)
Increasing this limit is a good idea. However, it makes sense to relate the maximum value with the number of host cpus - there is no much point in stressing the host to run a new qemu process while all its cpus are busy doing this.

--
To view, visit http://gerrit.ovirt.org/679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83b4f956619ee6cdfde5fdbec9d52484c355b33f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list