Change in vdsm[master]: rename rhevm bridge to brVDSM

danken at redhat.com danken at redhat.com
Sun Dec 25 20:03:54 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: rename rhevm bridge to brVDSM
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(5 inline comments)

please not that vdsm_cli/vdscli.py.in:49 still has

 proposed_addr = netinfo.ifconfig()['rhevm']['addr']

which should be changed, too. It would much nicer if clientIF._getServerIP() is moved to netinfo, and used by vdscli (in a separate patch).

....................................................
File vds_bootstrap/vds_bootstrap.py.in
Line 598:         #add @VDSMBRIDGE@ bridge
all replacements in this file is of logging strings and comments. Do we really need autoconf for that? wouldn't it be more economical to say "management bridge" instead?

....................................................
File vdsm_reg/deployUtil.py.in
Line 87: REMOTE_SSH_KEY_FILE = "/engine.ssh.key.txt"
wouldn't this kill registration to RHEV-3.0 ?

Line 559:             if key != '\n' and not key.endswith("== ovirt-engine") or key.startswith("#"):
this has to be a well-defined constant. and again, this change kills registration to rhev-m-3.0.

Line 779:                 "supported! Please configure " + MGT_BRIDGE_NAME + " bridge manually and re-install.")
now it's easy to break this line!

Line 1421:     parser.add_option("-d", "--download-" + MGT_BRIDGE_NAME + "-cert", action="store_true",
that's "engine" here!

and it must be the same as in the caller script vdsm_reg/vdsm-config

 python "$DEPLOY_UTIL" --download-rhevm-cert --server-address="$vdc_managment_server" --server-port="$vdc_managment_port" --fingerprint="$management_server_fingerprint"

--
To view, visit http://gerrit.ovirt.org/311
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Chris Wright <chrisw at sous-sol.org>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list