Change in vdsm[master]: Group the cluster lock code into a new SP method

ilvovsky at redhat.com ilvovsky at redhat.com
Fri Dec 23 17:48:24 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Group the cluster lock code into a new SP method
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 635:         self._acquireTemporaryClusterLock(msdUUID, safeLease)
It's related to this patch only because this patch add 2 more unnecessary domain produces. But, if you think that change it in different patch is good enough, It's fine for me.

--
To view, visit http://gerrit.ovirt.org/603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list