Change in vdsm[master]: Adding arbitrary disks to _drives.

danken at redhat.com danken at redhat.com
Thu Dec 22 22:07:58 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Adding arbitrary disks to _drives.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

sorry, only partial review.

....................................................
File vdsm/clientIF.py
Line 594:             path = drive
you've promised me to raise a proper exception if 'path' cannot be deduced!

....................................................
File vdsm/libvirtvm.py
Line 267:                 stats[dName].update(dLatency)
I think Engine expects the 0 values if we have a problem producing real values. Please discuss this change with Igor/Maor.

--
To view, visit http://gerrit.ovirt.org/626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea66e23c6c76e2b721255afb8becf913cdd70aa9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list