Change in vdsm[master]: Do not use lvm to get lv size if lv is active

abaron at redhat.com abaron at redhat.com
Wed Dec 21 21:36:07 UTC 2011


Ayal Baron has posted comments on this change.

Change subject: Do not use lvm to get lv size if lv is active
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/blockVolume.py
Line 86:             return _getDeviceSize(lvm.lvPath(sdobj.sdUUID, volUUID)) / bs
you should catch and failback to getLV in which case you don't even need to test if isLVActive and then the main path is even faster.

--
To view, visit http://gerrit.ovirt.org/677
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list