Change in vdsm[master]: Simplified Drive class.

ewarszaw at redhat.com ewarszaw at redhat.com
Tue Dec 20 07:59:14 UTC 2011


Eduardo has posted comments on this change.

Change subject: Simplified Drive class.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vm.py
Line 363:                 drv['iface'] = self.conf.get('if')
'if' a very distasteful name.
We want to change it to iface without changing the API. This was the cause of pop() which can raise KeyError.
Now we must use get(), for reusing the same conf, and we have (hopefully) the same value under two keys.
Brrr...
Better will be use the conf as a conf and not a status.

--
To view, visit http://gerrit.ovirt.org/625
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b33da25e5691910b9d58ecfb727e993991a4c83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list