Change in vdsm[master]: Minor refactoring

danken at redhat.com danken at redhat.com
Mon Dec 19 14:11:30 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Minor refactoring
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

-1 for visibility

....................................................
File vdsm/storage/sd.py
Line 88:         DOM_UNATTACHED_STATUS, DOM_ACTIVE_STATUS]
btw, who needs UNATTACHED? and why this is not a tupple?

--
To view, visit http://gerrit.ovirt.org/558
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b65e9714fb80d048e1ed244bb961ff8c2e205fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list