Change in vdsm[master]: Adding arbitrary disks to _drives.
ilvovsky at redhat.com
ilvovsky at redhat.com
Mon Dec 19 09:46:24 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: Adding arbitrary disks to _drives.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vm.py
Line 65: return getattr(self, 'poolID', False)
It's a little bit confusing. you already have a global function isVdsmImage().
So, maybe better to call one of them something like isVdsmDrive() ?
--
To view, visit http://gerrit.ovirt.org/626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea66e23c6c76e2b721255afb8becf913cdd70aa9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list