Change in vdsm[master]: Avoid to activate parent volume on cloning

ilvovsky at redhat.com ilvovsky at redhat.com
Sun Dec 18 14:18:55 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Avoid to activate parent volume on cloning
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 876:     size = int(size)
You right, the better way is always use size in bytes, but
I think that if you will look for createVolume in the code (especially in image.py )  you will figure out things like :

     tmpSize = 20480 # in sectors (10M)
     destDom.createVolume(...., size=tmpSize, .....)

--
To view, visit http://gerrit.ovirt.org/570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list