Change in vdsm[master]: Adding arbitrary disks to _drives.
ilvovsky at redhat.com
ilvovsky at redhat.com
Fri Dec 16 17:39:37 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: Adding arbitrary disks to _drives.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 64: return getattr(self, 'poolID', False)
As you know Ayal want deprecate poolID, so maybe 'domainID' will be better here
Line 355: confDrives.append({'device': 'cdrom', 'path': self.conf.get('cdrom', ''), 'blockDev': False, 'truesize': 0})
Just, split the line
--
To view, visit http://gerrit.ovirt.org/626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea66e23c6c76e2b721255afb8becf913cdd70aa9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list