Change in vdsm[master]: API: Separate clientIF and the xmlrpc server

danken at redhat.com danken at redhat.com
Fri Dec 16 14:32:08 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: API: Separate clientIF and the xmlrpc server
......................................................................


Patch Set 1: (3 inline comments)

Thanks Adam, I like the direction.

(no time for complete review now)

....................................................
File vdsm/clientIF.py
Line 131:                 file(constants.P_VDSM_CLIENT_LOG, 'w')
ouch, the original code is painfully intertwining the xmlrpc transport with functionality.

this touching of the P_VDSM_CLIENT_LOG file, is required by editNetwork in order to tell that it did not cut its line of communication.

this probably has to be fixed in another patch.

Line 173:         
painfully red

Line 290:             # stop listening ASAP
this comment has just rotten...

--
To view, visit http://gerrit.ovirt.org/620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list