Change in vdsm[master]: Add the live snapshot command to vdsClient

agl at us.ibm.com agl at us.ibm.com
Thu Dec 15 22:00:49 UTC 2011


Adam Litke has posted comments on this change.

Change subject: Add the live snapshot command to vdsClient
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1474:             vmDisk: {
Why do you pass in a vmDisk parameter when you don't even use it?  It looks like you are passing your own vmDisk that you construct from the sd, sp, img, and vol UUIDs.

--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list