Change in vdsm[master]: [WIP] Refactor mount logic

smizrahi at redhat.com smizrahi at redhat.com
Tue Dec 13 20:54:20 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: [WIP] Refactor mount logic
......................................................................


Patch Set 3: (4 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 923:             raise
If there is no stuck umount the aforementioned method does nothing. So you need to start fresh here. Anyway, it was in the old code as well.

....................................................
File vdsm/storage/fileUtils.py
Line 44: NFS_OPTIONS = "".join(config.get('irs', 'nfs_mount_options').split())
it shouldn't be in mount.py
it should be somewhere. I'd rather worry about that later

....................................................
File vdsm/storage/storage_connection.py
Line 369:                 self.log.error("Error during storage disconnection:", exc_info=True)
This keeps the original interface, will be overhauled anyway in the next patch

Line 418:                 rc = se.StorageException.code
This keeps the original interface, will be overhauled anyway in the next patch

--
To view, visit http://gerrit.ovirt.org/543
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list