Change in vdsm[master]: [WIP] Refactor mount logic

danken at redhat.com danken at redhat.com
Sun Dec 11 22:07:09 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Refactor mount logic
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/storage/fuser.py
Line 10:     (rc, out, err) = misc.execCmd(cmd,sudo=True)
thanks, but please keep out space-after-coma style.

....................................................
File vdsm/storage/mount.py
Line 41: def _parseFstabPath(path):
it's more of decoding than parsing, but ok.

--
To view, visit http://gerrit.ovirt.org/543
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca58303c13d8d7a4caed4a87b6a16b37651c359
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list