Change in vdsm[master]: Fix logging formatting in resourceManager

danken at redhat.com danken at redhat.com
Wed Dec 7 20:55:29 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Fix logging formatting in resourceManager
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

mainly wondering - why? just a matter of taste? (which I share)

....................................................
File vdsm/storage/resourceManager.py
Line 571:                             self._log.debug("Request '%s' was canceled, Ignoring it.", str(nextRequest))
is there anything wrong in using the generic % format operator?

(there is something superfluous and wrong in using str(), which croaks on unicode while '%s' handles it just fine)

--
To view, visit http://gerrit.ovirt.org/531
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08b530e8fbf66b9b8326cf1733df6a3e4f23ef1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list