Change in vdsm[master]: Naming conventions in Image._baseRawVolumeMerge temp files c...

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Dec 7 10:29:37 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Naming conventions in Image._baseRawVolumeMerge temp files changed.
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/image.py
Line 1023:         # Step 6: Remove _remove_me__successor subchain
the minor comment: step 6 is a not part of this function, it's part of caller

--
To view, visit http://gerrit.ovirt.org/445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4263f649e1936fcc1ccb7d5c094e9894f02fcd4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list