Change in vdsm[master]: caps.py/clientIF/libvirtvm: include oVirt Node

danken at redhat.com danken at redhat.com
Wed Dec 7 09:34:58 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: caps.py/clientIF/libvirtvm: include oVirt Node
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/caps.py
Line 130:         OSName.CURRENT = OSName.RHEV
OSName.CURRENT looks like a constant. You do not assign value to this dynamically.

....................................................
File vdsm/libvirtvm.py
Line 996:             osname=caps.OSName.CURRENT,
no, this has to be RHEVH, even for RHEL host. do not ask... and RHN requirement.

--
To view, visit http://gerrit.ovirt.org/454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e59867abaf4cd6e9f142356b05fca15992ae300
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list