Change in vdsm[master]: vdsm: new verb: migration cancel

ilvovsky at redhat.com ilvovsky at redhat.com
Tue Dec 6 07:31:17 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: vdsm: new verb: migration cancel
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Should we change VM statuses from 'Migration Source' to prior value after migration cancellation?

....................................................
File vdsm/define.py
Line 45:             'migCancelErr': {'status': {'code':45, 'message': 'Migration not in progress'}},
I am already using error codes 45,46 for hotplug.
I know that first merged patch should win, but because hotplug patch already in gerrit and to avoid unnecessary rebases in the feature please consider to change error code to 47

--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list