Change in vdsm[master]: The configuration values must be strings

fsimonce at redhat.com fsimonce at redhat.com
Thu Dec 1 12:55:11 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: The configuration values must be strings
......................................................................


Patch Set 2:

> BTW, config.parameters should be called _parameters.
> I even dare to suggest that they should be deleted after use.

We didn't discuss this but I thought it was nice to expose them instead. Any tool would have the opportunity to read the comments and the default values (for example we could have something like: "vdsm-tool help vars vm_sample_disk_latency_interval" to display the comment/default). I remember I spent some time researching if it was possible doing it in ConfigParser object but it wasn't (I should have subclassed it).

--
To view, visit http://gerrit.ovirt.org/459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id51af12b809906848f9dfbde17c42ce56b887772
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list