Change in vdsm[master]: The configuration values must be strings

danken at redhat.com danken at redhat.com
Thu Dec 1 11:15:38 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: The configuration values must be strings
......................................................................


Patch Set 2: Looks good to me, approved

Grr, I should have noticed that error message when verifying your patch.

BTW, config.parameters should be called _parameters. I even dare to suggest that they should be deleted after use.

--
To view, visit http://gerrit.ovirt.org/459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id51af12b809906848f9dfbde17c42ce56b887772
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list