Change in vdsm[master]: fix getMasterDomain masterVersion handling

ilvovsky at redhat.com ilvovsky at redhat.com
Thu Dec 1 09:26:11 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: fix getMasterDomain masterVersion handling
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 10: perform the mserterVersion equality test
mserterVersion  -> masterVersion

....................................................
File vdsm/storage/sp.py
Line 662: 
How this one related to the patch?

Line 1495:         if version != masterVersion and masterVersion != -1:
What is it?   Why?  We expect that master domain has exactly same version as it got. All other cases should raise exception.

--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list