[NEW PATCH] Fix new killall (via gerrit-bot)
Saggi Mizrahi
smizrahi at redhat.com
Wed Aug 31 11:08:29 UTC 2011
New patch submitted by Saggi Mizrahi (smizrahi at redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/871
commit 3797a10d6e037eb39e6587ee5f0a4c3d65579009
Author: Saggi Mizrahi <smizrahi at redhat.com>
Date: Wed Aug 31 14:00:03 2011 +0300
Fix new killall
Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index b16df9b..247211d 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -1224,11 +1224,11 @@ class OperationMutex(object):
self._lock.release()
self._cond.notifyAll()
-def killall(signum, name, group=False):
+def killall(name, signum, group=False):
exception = None
knownPgs = set()
pidList = pgrep(name)
- if len(pidList):
+ if len(pidList) == 0:
raise OSError(errno.ESRCH, "Could not find processes named `%s`" % name)
for pid in pidList:
@@ -1240,7 +1240,7 @@ def killall(signum, name, group=False):
continue
knownPgs.add(pgid)
- os.killpg(pgid)
+ os.killpg(pgid, signum)
else:
os.kill(pid, signum)
except OSError, e:
More information about the vdsm-patches
mailing list