Change in vdsm[master]: BZ#728958 Don't check read delay when domain was not produce...

danken at redhat.com danken at redhat.com
Tue Aug 30 21:43:26 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#728958 Don't check read delay when domain was not produced
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 110:             except AttributeError:
isn't this an overcomplex way to check if self._domain is None?

I hate indentation like anybody, but isn't another conditional the solution here?

--
To view, visit http://gerrit.usersys.redhat.com/801
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9a0d62299136cd8011f0e550373900b04ec3af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list