Change in vdsm[master]: BZ#733373, BZ#677149 - Assert cleanupSpmLinks success.

danken at redhat.com danken at redhat.com
Mon Aug 29 23:30:07 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#733373, BZ#677149 - Assert cleanupSpmLinks success.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/spm.py
Line 228:         misc.execCmd(['rm', "-rf", vms, tasks])
why do you trust `rm` more than ourselves? Is there a race here? wouldn't it stay?
use EXT_RM if you have a good excuse.

--
To view, visit http://gerrit.usersys.redhat.com/864
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id16baf5c23a7b71f25030c0443710f9412252367
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list