Change in vdsm[master]: BZ#732765 - Don't return empty strings for 'disktotal'/'disk...

danken at redhat.com danken at redhat.com
Mon Aug 29 23:18:07 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#732765 - Don't return empty strings for 'disktotal'/'diskfree' on unreachable domains during getStoragePoolInfo
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 1078:                                 del(stats['disktotal'])
I think 

stats.pop('disktotal')

is nicer (no need for try-except) and a bit safer, since the 'disktotal' could be missing while 'diskfree' remain.

--
To view, visit http://gerrit.usersys.redhat.com/862
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ae55b4942cf5748d3d8ada445a3381498ea258
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list