Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running

danken at redhat.com danken at redhat.com
Mon Aug 29 23:14:07 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

David said he had problem with a similar fix.

....................................................
File vdsm/libvirtconnection.py
Line 119:                 conn.domainEventRegisterAny(None, ev, __eventCallback, (cif, ev))
why should we continue? this would explode with NoneType.

--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list