Change in vdsm[master]: BZ#733909 - get SPM id from lease instead of metadata

danken at redhat.com danken at redhat.com
Mon Aug 29 23:09:11 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#733909 - get SPM id from lease instead of metadata
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/storage/safelease.py
Line 74:             #Read 512 because you can't read less with direct io
then shouldn't this be a CONSTANT of fileUtils?

Line 81:             stamp = int(tag[ID_LEN:TAG_LEN], 16)
timestamp is clearer

--
To view, visit http://gerrit.usersys.redhat.com/860
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I582ae24aa843ad33e48a4cdd1e51b059355d132f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list