Change in vdsm[master]: BZ#731750 - handle missing libvirt lograte config

Saggi Mizrahi smizrahi at redhat.com
Sun Aug 28 13:50:55 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#731750 - handle missing libvirt lograte config
......................................................................


Patch Set 1: (1 inline comment)

selinux is fun

....................................................
File vdsm/vdsmd.in
Line 345:     restorecon "$llogr"
Files get their context upon creation and then it sticks to the inode. mv actually renames the files keeping the original inode and the original context. If the file was created in /etc/logrotate.d/ it would have gotten the correct permissions. Because the file is created in /tmp it gets /tmp context. Files installed with rpm are created in the target folder and get the correct default context. If you want to set a different context on any installed file you have to set the policy and in %post restore con the files. This is not needed in VDSM AFAIK.

--
To view, visit http://gerrit.usersys.redhat.com/856
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If909667a96a75df9070baca4054406a465cb11e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list