Change in vdsm[master]: [WIP] BZ#732980 Handle 4K block size LUN properly

Federico Simoncelli fsimonce at redhat.com
Fri Aug 26 15:32:55 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: [WIP] BZ#732980 Handle 4K block size LUN properly
......................................................................


Patch Set 1: (4 inline comments)

Initial implementation. The "create MD areas as multiples of BS" part is still missing.

....................................................
File vdsm/storage/hsm.py
Line 760:                         'blocksize': dev.get("blocksize", ""),
I believe it's nice to communicate this information to RHEVM. It's also useful in the ruth tests to check that we actually have different block sizes.
See: http://gerrit.usersys.redhat.com/851

....................................................
File vdsm/storage/multipath.py
Line 229:                 "blocksize" : "",
It's nice to have and communicate this information. See also the comments in the other files.

Line 259:                     devInfo["blocksize"] = "%i:%i" % (logBlkSize, phyBlkSize)
Any objection to this format? We need both values? Feedback is welcome.

....................................................
File vdsm/storage/storage_exception.py
Line 1002: class VolumeGroupBlockSizeError(StorageException):
We should notify this new exception to RHEVM.

--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list