Change in vdsm[master]: Related to BZ#726400 - ISO domain on block is not supported.

Eduardo Warszawski ewarszaw at redhat.com
Thu Aug 25 15:11:48 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#726400 - ISO domain on block is not supported.
......................................................................


Patch Set 2:

The removed code is _dead_ code.
Since a block domain actually can't be iso, this condition is (identically) false.
In the new flow in http://10.35.18.144/#change,832 the iso directory can't be created since the domain should not be produced. Therefore is impossible to check this condition.
This dead code here is very assymetric.
If iso block support will be added in the future, should be added properly.
Probably the iso domain will be removed before.

--
To view, visit http://10.35.18.144/831
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02639f9da4a978f018ee719025483e90447a140b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list