Change in vdsm[master]: Use the correct events to end migration

Federico Simoncelli fsimonce at redhat.com
Tue Aug 23 07:53:24 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Use the correct events to end migration
......................................................................


Patch Set 2: (1 inline comment)

Let's leave this review for when Dan will return. It's not urgent. We didn't have a race, the real problem was a broken libvirt build.

....................................................
File vdsm/libvirtvm.py
Line 1268:         elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED:
For sure we need to group them. I also wonder why we need to check the lastStatus every time. I have many questions... let's leave this review for when Dan will be back.

--
To view, visit http://gerrit.usersys.redhat.com/782
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3833bee7da8a3fbd77ad72c244f714b929005e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list