[NEW PATCH] Check for pyflakes to be installed (via gerrit-bot)

Federico Simoncelli fsimonce at redhat.com
Mon Aug 22 16:00:15 UTC 2011


New patch submitted by Federico Simoncelli (fsimonce at redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/844

commit f1eaed474ec6aa7834e63eaf9093f395635fad27
Author: Federico Simoncelli <fsimonce at redhat.com>
Date:   Mon Aug 22 15:58:09 2011 +0000

    Check for pyflakes to be installed
    
    Change-Id: Ia7e535ebe130aa9bd93b036c7e7ead7258ccd739

diff --git a/Makefile.am b/Makefile.am
index 71ac5ae..011ac65 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -14,7 +14,7 @@ rpmrelease = @PACKAGE_RELEASE@
 RPMTOP = $(PWD)/rpmtop
 
 check-local:
-	pyflakes $(SUBDIRS)
+	$(PYFLAKES) $(SUBDIRS)
 
 .PHONY: srpm rpm
 
diff --git a/configure.ac b/configure.ac
index bb4c3e4..e44e47d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,6 +45,12 @@ AC_SUBST([vdsmregdir], ['${datarootdir}/vdsm-reg'])
 AC_SUBST([vdsmregconfdir], ['${sysconfdir}/vdsm-reg'])
 AC_SUBST([vdsmreglogdir], ['${localstatedir}/log/vdsm-reg'])
 
+# Checking for pyflakes
+AC_PATH_PROG([PYFLAKES], [pyflakes])
+if test "x$PYFLAKES" = "x"; then
+  AC_MSG_ERROR([pyflakes not found, please install it.])
+fi
+
 # External programs (sorted, please keep in order)
 AC_PATH_PROG([BLOCKDEV_PATH], [blockdev], [/sbin/blockdev])
 AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])




More information about the vdsm-patches mailing list