Change in vdsm[master]: Remove all the references to VDC from logging
Igor Lvovsky
ilvovsky at redhat.com
Sun Aug 21 08:24:52 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: Remove all the references to VDC from logging
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 569: self.message = "No route. Check switch/router settings and try registration again"
"No route"? why/which route?
Can you consider to change VDC -> RHEV-M, I think that it's more informative
Line 606: self.message = "Faild to parse URL!"
same as above
....................................................
File vdsm_reg/deployUtil.py.in
Line 275: logging.debug("_getMGTIface: read vdc_host_name: " + strVDCName)
vdc_host_name ?
Line 280: logging.debug("_getMGTIface: error trying to figure out IP")
What do you think about just change VDC -> RHEV-M.
IMHO if we decided to add log here, let's explain which IP is problematic
Line 282: logging.debug("_getMGTIface: using vdc_host_name " + strVDCName + " strIP= " + strVDCIP)
vdc_host_name ?
Line 288: logging.debug("_getMGTIface IP=" + str(strVDCIP) + " strIface=" + str(strReturn))
same as above
--
To view, visit http://gerrit.usersys.redhat.com/833
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7579934bc000e0cbd7891fd8104d178f9d155e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list