Change in vdsm[master]: Don't override the rpm topdir macro settings

Federico Simoncelli fsimonce at redhat.com
Thu Aug 18 15:27:15 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Don't override the rpm topdir macro settings
......................................................................


Patch Set 3:

My workflow is:

 $ make rpm
 $ scp -p (copy the rpm paths with a doubleclick [1]) root at host:

[1] this is particularly easy because the make process prints the correct path to the rpms at the end of each build.

Once in a while I clean ~/rpmbuild (which for me is considered temporary and doesn't contain anything important).
I don't feel strongly about one or the other solution. I preferred this one because it's in the mentality of focusing only on what you need without overriding other components defaults (or users settings).

Adding a "rm -rf rpmtop" is not hard. It's easy even with automake... which by the way doesn't offer a RM_RF macro, (but it offers RM, LN_S, MKDIR_P)... hint :).

--
To view, visit http://gerrit.usersys.redhat.com/826
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia84386fb980745107c7d664900effcbc0bb2d18e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list