Change in vdsm[master]: Related to BZ#728381 - Add additional 'alert' in getStorage...

Eduardo Warszawski ewarszaw at redhat.com
Wed Aug 17 14:31:54 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#728381 -  Add additional 'alert' in getStoragePoolInfo if VG metadata smaller than 60M
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 717:     @classmethod
IMHO this is not a class method.
This should be an unbound module function.

....................................................
File vdsm/storage/storage_exception.py
Line 1151:     message = """Error - The system has reached the 80% watermark on the VG metadata area size.
This is a fixed mesage,. Please remove numbers and percentages.

Line 1159:     message = """Warning - The allocated VG metadata area size is smaller than 60MB, which might limit
This is a fixed mesage,. Please remove numbers and percentages.

--
To view, visit http://gerrit.usersys.redhat.com/809
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce978f2a8b059c157256ca6c22db7ef5ee8ab38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list