Change in vdsm[master]: BZ#728381 - Return 'alerts' key for each domain in getStorag...

Eduardo Warszawski ewarszaw at redhat.com
Wed Aug 17 08:39:28 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: BZ#728381 - Return 'alerts' key for each domain in getStoragePoolInfo query
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File vdsm/storage/lvm.py
Line 137: MDA_MIN_THRESHOLD = 0.2
As discussed, since we are defining the size of the metadata in upper layers, and not in lvm anymore move to config.
Threshold is relative to the size of the disk, as the size of the metadata should be, please define it in the config.

Line 1194: def isMetadataSizeValid(vgName):
Bad name.

....................................................
File vdsm/storage/storage_exception.py
Line 1152: 
Add additional params VG and sizes.

--
To view, visit http://gerrit.usersys.redhat.com/808
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62f80bfaa2044eab541101de5b2825aa895c5d04
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list