Change in vdsm[master]: Related to BZ#728381 - Add additional 'alert' in getStorage...

Igor Lvovsky ilvovsky at redhat.com
Wed Aug 17 09:15:25 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#728381 -  Add additional 'alert' in getStoragePoolInfo if VG metadata smaller than 60M
......................................................................


Patch Set 2: (9 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 716:     def metadataValidity(cls, vg):
It was changed according Dan's requests.
As you know, every 2 developers have 3 names for same function

Line 722:         mdaStatus = {'mdavalid':True, 'mdathreshold':True}
I already published  'mdathreshold ' for z-stream and RHEV-M use it.
So, I can't changed it anymore

Line 726:         if mda_size < lvm.METADATASIZE/2:
Done

....................................................
File vdsm/storage/lvm.py
Line 137: 
Done

Line 694: def _initpv(device, withmetadata=False):
Done

Line 697:         metadatasize = str(METADATASIZE/1024) + 'K'
Done

....................................................
File vdsm/storage/sp.py
Line 1066:                             self.log.warning("VG %s's metadata size too small", dom.sdUUID)
Done

Line 1071:                             self.log.warning("VG %s's metadata size exceeded critical size", dom.sdUUID)
Done

....................................................
File vdsm/storage/storage_exception.py
Line 1155:     message = """Warning - The allocated VG metadata area size is smaller than 60MB, which might limit
we cannot do it because RHEV-M limitations. They can't deal with dynamic strings in messages

--
To view, visit http://gerrit.usersys.redhat.com/809
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce978f2a8b059c157256ca6c22db7ef5ee8ab38
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list