Change in vdsm[master]: Related to BZ#728381 - Add additional 'alert' in getStorage...

Eduardo Warszawski ewarszaw at redhat.com
Tue Aug 16 13:41:50 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: Related to BZ#728381 -  Add additional 'alert' in getStoragePoolInfo if VG metadata smaller than 60M
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(8 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 722:         mdaStatus = {'mdavalid':True, 'mdathreshold':True}
Replace:
mdathreshold by mdaAllmostFull.
mdavalid should be mdaSmall.

Line 726:         if mda_size < lvm.METADATASIZE/2:
METADATASIZE is compared only here, it is not part of lvm semantics.
The constant should be not defined in the lvm module.

....................................................
File vdsm/storage/lvm.py
Line 137: 
Define it in blockSD.

Line 694: def _initpv(device, withmetadata=False):
Replace withmetadata by metadataSize.

Line 697:         metadatasize = str(METADATASIZE/1024) + 'K'
Should be 'k' for [KiB].
See man lvm.
IMHO would be better to replace the withmetadata parameter with metadataSize.

....................................................
File vdsm/storage/sp.py
Line 1066:                             self.log.warning("VG %s's metadata size too small", dom.sdUUID)
Return the metadasize in dict and log it here.

Line 1071:                             self.log.warning("VG %s's metadata size exceeded critical size", dom.sdUUID)
Add log filledSize from totalMDSize.

....................................................
File vdsm/storage/storage_exception.py
Line 1155:     message = """Warning - The allocated VG metadata area size is smaller than 60MB, which might limit
The limit in text should be a parameter.

--
To view, visit http://gerrit.usersys.redhat.com/809
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icce978f2a8b059c157256ca6c22db7ef5ee8ab38
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list