Change in vdsm[master]: Fix the storage exception check
Federico Simoncelli
fsimonce at redhat.com
Tue Aug 16 10:48:11 UTC 2011
Federico Simoncelli has posted comments on this change.
Change subject: Fix the storage exception check
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/storage_exception.py
Line 1292: for name, obj in globals().items():
This code runs only when globals() == objects of this module. Its advantage is that it returns items in the form ("obj_name", obj_ref) which is perfect for what we need.
I didn't find anything else that could provide this without additional work.
--
To view, visit http://gerrit.usersys.redhat.com/812
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7df992f96522bb2989a5cd05b713f55e6dd6d48b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list