Change in vdsm[master]: subprocess' shell parameter is evil

Igor Lvovsky ilvovsky at redhat.com
Mon Aug 15 12:40:13 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: subprocess' shell parameter is evil
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 537:             fileUtils.tarCopy(src, dst, exclude="./lost+found")
According to tarCopy implamantation 'exclude' should be a list:
exclude=["./lost+found"]

--
To view, visit http://gerrit.usersys.redhat.com/803
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b9978e9acd9d848123b6b0908ede2b21e46e758
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list