Change in vdsm[master]: Fix make distcheck

Saggi Mizrahi smizrahi at redhat.com
Mon Aug 15 09:04:43 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: Fix make distcheck
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/mk-vdsm-conf-sample.py
Line 8:     sys.exit(-1)
Exist takes an error string not a number

Line 12: for line in file(sys.argv[1]).readlines():
with file(sys.argv[1]) as f:
   for line in f:

--
To view, visit http://gerrit.usersys.redhat.com/805
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea26d65baf633265e201094e1c2c40859276203
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list