[NEW PATCH] BZ#722649 - Invalidate domain MD in removeStorageDomain() (via gerrit-bot)

Dan Kenigsberg danken at redhat.com
Thu Aug 11 21:17:38 UTC 2011


New patch submitted by Dan Kenigsberg (danken at redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/728

commit 9251c92f80f56d7653401f64d2fe01db893e36ce
Author: Saggi Mizrahi <smizrahi at redhat.com>
Date:   Wed Jul 20 14:40:18 2011 +0300

    BZ#722649 - Invalidate domain MD in removeStorageDomain()
    
    Because the pool might have been destroyed on another host without this
    host's knowledge, don't trust the MD cache before formatting.
    
    Change-Id: Ib436aa6b871014f87d2cd9929e7122d807f29ade

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 0c3e783..5799c8f 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1237,7 +1237,9 @@ class HSM:
         if not misc.parseBool(autoDetach):
             # Allow format also for broken domain
             try:
-                if len(SDF.produce(sdUUID=sdUUID).getPools()) > 0:
+                dom = SDF.produce(sdUUID=sdUUID)
+                dom.invalidateMetadata()
+                if len(dom.getPools()) > 0:
                     raise se.CannotFormatAttachedStorageDomain(sdUUID)
 
             except (se.StorageDomainMetadataNotFound, se.MetaDataGeneralError, se.MiscFileReadException,




More information about the vdsm-patches mailing list