Change in vdsm[master]: Get dmId from device number instead of looking for it

danken at redhat.com danken at redhat.com
Thu Aug 11 21:14:34 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Get dmId from device number instead of looking for it
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/devicemapper.py
Line 20:     # udev configuration. Falling back to slow but sure method
wouldn't this be (slightly) raceful? udev can decide on line 20 that it suddenly generates the symlink named devlinkPath.

Why do we need 2 checks? This latter one is a simple as the former and is more robust.

Line 25:             if f.read() == deviceMultipathName:
when do we expect to find another name here?

--
To view, visit http://gerrit.usersys.redhat.com/757
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa0444e370eb65c7251e4b1afaecff93e0cf937
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list