Change in vdsm[master]: BZ#705058 - Don't create a new pool object on storage refres...
Igor Lvovsky
ilvovsky at redhat.com
Thu Aug 11 15:07:22 UTC 2011
Igor Lvovsky has posted comments on this change.
Change subject: BZ#705058 - Don't create a new pool object on storage refresh
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 174: #TODO Once we support simultaneous connection to multiple pools, remove following line (break)
You never should call public_xxx from the code.
It's external API only.
How it works at all, if you pass master domain and versions as None
....................................................
File vdsm/storage/sp.py
Line 419:
Why you need this function?
--
To view, visit http://gerrit.usersys.redhat.com/796
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40d86257c239736c74d715775bcc27cab4613125
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list