Change in vdsm[master]: Fix make distcheck

Federico Simoncelli fsimonce at redhat.com
Wed Aug 10 07:54:17 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: Fix make distcheck
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File Makefile.am
Line 19: .PHONY: exceptions pyflakes srpm rpm
not completely. "TESTS = pyflakes" makes distcheck fail. Since I was at it I also reorganized its .PHONY entry.

....................................................
File vdsm/vdsm-conf-sample.py
Line 1: #!/usr/bin/python
I hated those dots inside the name, also the underscore is more unusual than the dash. Not a big problem, just my taste :-) Let me know if I need to revert this.

--
To view, visit http://gerrit.usersys.redhat.com/805
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea26d65baf633265e201094e1c2c40859276203
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list