Change in vdsm[master]: don't subprocess for killall

danken at redhat.com danken at redhat.com
Tue Aug 9 20:12:07 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: don't subprocess for killall
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Please provide an explanation why this is a good idea (quicker, hopefully more robust).

Please also remove KILLALL from constants and configure.ac

--
To view, visit http://gerrit.usersys.redhat.com/804
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I035ed5f5eb3a2f3d4aadda83ddf0fc7dca07fd1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list