Change in vdsm[master]: BZ#728958 Don't check read delay when domain was not produce...

danken at redhat.com danken at redhat.com
Mon Aug 8 20:07:20 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#728958 Don't check read delay when domain was not produced
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 107:                 # If we couldn't retrieve the domain object there is something
If I were Edu, I'd say that your new code is not expected to raise an exception and should live within try:except.

Line 111:                     continue
ok, you cannot get 'delay', but why not report 'code'?

--
To view, visit http://gerrit.usersys.redhat.com/801
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9a0d62299136cd8011f0e550373900b04ec3af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list