[NEW PATCH] Related to BZ#704131 - Simplify getDomains. (via gerrit-bot)

Eduardo Warszawski ewarszaw at redhat.com
Sun Aug 7 14:46:48 UTC 2011


New patch submitted by Eduardo Warszawski (ewarszaw at redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/762

commit 0088fe20a778fe70f6e5e83a48692eefe16e73d3
Author: Eduardo Warszawski <ewarszaw at redhat.com>
Date:   Mon Jul 25 16:15:38 2011 +0300

    Related to BZ#704131 - Simplify getDomains.
    
    Change-Id: I332524d5e2a060ed11cb2d2b78235701080cb6fe

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 8d2eebb..4df9efc 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -1188,14 +1188,9 @@ class StoragePool:
                     self.log.error("Unexpected error while trying to monitor domain `%s`", sdUUID, exc_info=True)
 
     def getDomains(self, activeOnly=False):
-        doms = self.getMetaParam(PMDK_DOMAINS)
-        if activeOnly:
-            for sdUUID in doms.keys():
-                status = doms[sdUUID]
-                if status != sd.DOM_ACTIVE_STATUS:
-                    del doms[sdUUID]
-
-        return doms
+        return dict((sdUUID, status) \
+               for sdUUID, status in self.getMetaParam(PMDK_DOMAINS).iteritems() \
+               if not activeOnly or status == sd.DOM_ACTIVE_STATUS)
 
     def checkBackupDomain(self):
         domDict = self.getDomains(activeOnly=True)




More information about the vdsm-patches mailing list