Change in vdsm[master]: BZ#704131 - Activate all image volumes at once.

danken at redhat.com danken at redhat.com
Sun Aug 7 08:29:34 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#704131 - Activate all image volumes at once.
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/resourceFactories.py
Line 134:         if dom.__class__.__name__ == "BlockStorageDomain":
how about calling a new class method of BlockStorageDomain? but that's ugly too...

--
To view, visit http://gerrit.usersys.redhat.com/771
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8423260ca92eb522239064403d3833002e048375
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list