Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.

danken at redhat.com danken at redhat.com
Thu Aug 4 11:26:11 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 7: vdsm: bz#727871: rewrote the messages handling code.
BZ#727871: guestIF: rewrite the message reading code

....................................................
File vdsm/guestIF.py
Line 257:     def _readMessages(self):
pretty please - rename. it is VERY confusing with _readMessage() below that has completely different behavior.

Line 270:         self._buffer += s
why didn't you move this up?
here there is a chance that s is not defined yet (think self._stopped)

--
To view, visit http://10.35.18.144/785
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list